[PATCH] D115317: [dfsan] Add a flag to ignore personality routines.

Taewook Oh via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 8 13:30:37 PST 2021


twoh added a comment.

@browneee Thanks for the pointer!

> Can continuing execution after an exception could lead to false positives? I'm unsure how primitives on the stack frames are freed during unwind - will stack shadow memory be zero'd during unwinding?

I don't think stack shadow memory will be zero'd during unwinding, but I also don't think that it will lead to false positives. I think it's basically same as we only adjust the stack/frame pointers to manage stack, not explicitly zero'ing out the stack. Once we push a new value to stack, the corresponding shadow instruction will overwrite the stack shadow memory as well. Please let me know if I misunderstood something. (I guess HWASAN requires explicit untagging because they want to detect the stack overflow.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115317/new/

https://reviews.llvm.org/D115317



More information about the llvm-commits mailing list