[llvm] aff028f - [lit] Pass the COMSPEC variable through to test processes on Windows

Martin Storsjö via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 8 13:30:27 PST 2021


Author: Martin Storsjö
Date: 2021-12-08T23:29:39+02:00
New Revision: aff028f7d8322c625422febd3d8b9794746cdc5b

URL: https://github.com/llvm/llvm-project/commit/aff028f7d8322c625422febd3d8b9794746cdc5b
DIFF: https://github.com/llvm/llvm-project/commit/aff028f7d8322c625422febd3d8b9794746cdc5b.diff

LOG: [lit] Pass the COMSPEC variable through to test processes on Windows

This variable is necessary for the system() function for running
external processes.

This is needes for some libcxx tests. With the current libcxx test
infrastructure, all OS environment variables are passed through, but
with the new "from scratch" libcxx test setup, we only pass through
the variables listed here.

Differential Revision: https://reviews.llvm.org/D115363

Added: 
    

Modified: 
    llvm/utils/lit/lit/TestingConfig.py

Removed: 
    


################################################################################
diff  --git a/llvm/utils/lit/lit/TestingConfig.py b/llvm/utils/lit/lit/TestingConfig.py
index 37558bd5059c0..e80369377857b 100644
--- a/llvm/utils/lit/lit/TestingConfig.py
+++ b/llvm/utils/lit/lit/TestingConfig.py
@@ -31,6 +31,7 @@ def fromdefaults(litConfig):
                      'WindowsSDKLibVersion', 'SOURCE_DATE_EPOCH']
 
         if sys.platform == 'win32':
+            pass_vars.append('COMSPEC')
             pass_vars.append('INCLUDE')
             pass_vars.append('LIB')
             pass_vars.append('PATHEXT')


        


More information about the llvm-commits mailing list