[PATCH] D115387: [instcombine] Canonicalize constant index type to i64 for extractelement/insertelement

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 8 13:27:07 PST 2021


nikic added a comment.

Canonicalizing this sounds generally reasonable, but why towards i64 rather than i32? We require i32 for shuffle masks, and it's the canonical type for struct indices, so it seems like the more natural choice, and would probably result in less test diffs.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115387/new/

https://reviews.llvm.org/D115387



More information about the llvm-commits mailing list