[PATCH] D115370: [NFC] Replace some deprecated getAlignment() calls with getAlign()
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 8 13:23:45 PST 2021
arsenm added inline comments.
================
Comment at: llvm/lib/Analysis/MemoryBuiltins.cpp:595
-APInt ObjectSizeOffsetVisitor::align(APInt Size, uint64_t Alignment) {
+APInt ObjectSizeOffsetVisitor::align(APInt Size, MaybeAlign Alignment) {
if (Options.RoundToAlign && Alignment)
----------------
Don't see why this wouldn't just be Alignment (really I don't know why we have MaybeAlign at all)
================
Comment at: llvm/lib/IR/AsmWriter.cpp:4243
+ if (MaybeAlign A = AI->getAlign()) {
+ Out << ", align " << A->value();
}
----------------
probably should add a direct raw_ostream overload?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115370/new/
https://reviews.llvm.org/D115370
More information about the llvm-commits
mailing list