[PATCH] D115053: [Bazel] Switch LLVM targets based on configuration flags.

[Itai Zukerman via Phabricator via llvm-commits]

izuk marked an inline comment as done.
izuk added a comment.

I tried to address all the documentation comments.



================
Comment at: utils/bazel/llvm-project-overlay/llvm/BUILD.bazel:1775
         name = target["name"] + "Info",
         srcs = ["lib/Target/" + target["name"] + "/TargetInfo/" + target["name"] + "TargetInfo.cpp"],
         hdrs = glob(["lib/Target/" + target["name"] + "/TargetInfo/*.h"]),
----------------
GMNGeoffrey wrote:
> Perhaps we should select out all srcs if the target isn't enabled. Then there's no chance some other dependency is going to pull in anything from a disabled target
Not sure I understand.  Do you mean, have the Bazel target but with an empty srcs?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115053/new/

https://reviews.llvm.org/D115053