[PATCH] D114899: [llvm-profgen] Turn on cold profile trimming by default for non-CS profile

[Wenlei He via Phabricator via llvm-commits]

wenlei accepted this revision.
wenlei added a comment.

lgtm with a nit.



================
Comment at: llvm/tools/llvm-profgen/ProfileGenerator.cpp:392-394
+  if (!ProfileSummaryCutoffCold.getNumOccurrences() &&
+      !ProfileSummaryColdCount.getNumOccurrences())
+    ColdCntThreshold = 10;
----------------
If this functions takes `ColdCntThreshold` already, it'd be better to move the cold threshold setting out of it and pass in the final value. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114899/new/

https://reviews.llvm.org/D114899