[PATCH] D115333: [flang][codegen] Add a conversion for `fir.coordinate_of` - part 2
Valentin Clement via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 8 10:22:03 PST 2021
clementval added inline comments.
================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:2651
+ bool validCoordinate(mlir::Type type, mlir::ValueRange coors) const {
+ const auto sz = coors.size();
+ std::remove_const_t<decltype(sz)> i = 0;
----------------
replace `auto`
================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:2656
+ for (; i < sz; ++i) {
+ auto nxtOpnd = coors[i];
+ if (auto arrTy = type.dyn_cast<fir::SequenceType>()) {
----------------
replace `auto`
================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:2680
+ bool arraysHaveKnownShape(mlir::Type type, mlir::ValueRange coors) const {
+ const auto sz = coors.size();
+ std::remove_const_t<decltype(sz)> i = 0;
----------------
replace `auto`
================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:2683
+ for (; i < sz; ++i) {
+ auto nxtOpnd = coors[i];
+ if (auto arrTy = type.dyn_cast<fir::SequenceType>()) {
----------------
replace `auto`
================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:2798
+
+ auto currentObjTy = fir::dyn_cast_ptrOrBoxEleTy(baseObjectTy);
+ assert(currentObjTy.dyn_cast<fir::SequenceType>() ||
----------------
================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:2818
+ if (!hasKnownShape) {
+ const auto sz = arrTy.getDimension();
+ if (arraysHaveKnownShape(arrTy.getEleTy(),
----------------
================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:2821
+ operands.drop_front(1 + sz))) {
+ auto shape = arrTy.getShape();
+ bool allConst = true;
----------------
================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:2847
+ }
+ const auto sz = operands.size();
+ Optional<int> dims;
----------------
================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:2851
+ for (std::remove_const_t<decltype(sz)> i = 1; i < sz; ++i) {
+ auto nxtOpnd = operands[i];
+
----------------
`auto`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115333/new/
https://reviews.llvm.org/D115333
More information about the llvm-commits
mailing list