[PATCH] D112748: [release] Use the Bootstrapping build for building LLVM releases

Wed Dec 8 09:29:43 PST 2021

phosek added a comment.

In D112748#3116822 <https://reviews.llvm.org/D112748#3116822>, @ldionne wrote:

> In D112748#3097513 <https://reviews.llvm.org/D112748#3097513>, @phosek wrote:
>
>> In D112748#3094557 <https://reviews.llvm.org/D112748#3094557>, @ldionne wrote:
>>
>>> @phosek With this patch as-is, we end up not building the runtimes at all because `install-runtimes` isn't executed when we run `ninja -C build`. I *think* that's because `install-runtimes` is not added to the `ALL` target in CMake. Is that voluntary or is it an oversight?
>>
>> That's because nobody ever asked for it. From what I know, all users of the bootstrapping build use the distribution support <https://llvm.org/docs/BuildingADistribution.html>.
>>
>> I'm fine including `install-runtimes` in the `ALL` target, but I also think that releases should ideally be using distribution support.
>
> Oh, well, in that case, I think we should definitely be using the distribution support. @phosek any appetite for commandeering this to migrate `test-release.sh` to a proper distribution build?

@ldionne That's going to be a larger change so I'd prefer starting with this one and switching to distribution build as a follow up change.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112748/new/

https://reviews.llvm.org/D112748