[PATCH] D115327: [WebAssembly] Fix reftype load/store match with idx from call

Paulo Matos via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 8 06:58:57 PST 2021


pmatos planned changes to this revision.
pmatos added a comment.

I think this needs to be more generic, rather than allowing just calls... as I found a similar problem when the node is a CopyFromReg. I will refactor this patch.



================
Comment at: llvm/test/CodeGen/WebAssembly/externref-tableset.ll:82
 
+declare i32 @get_table_id() local_unnamed_addr
+
----------------
sbc100 wrote:
> Is this returning the ID of a table, or the ID of slot within a table?  I seem like its the latter, in which case maybe its name is a little confusing?  How about calling this `get_table_slot` ?
You're right, it's the latter. I will rename.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115327/new/

https://reviews.llvm.org/D115327



More information about the llvm-commits mailing list