[PATCH] D115138: [llvm-mca] Compare multiple files

[Andrea Di Biagio via Phabricator via llvm-commits]

andreadb added a comment.

If the user doesn't specify an -mtriple, then we shouldn't pass a default. llvm-mca should be able to deduce the default target triple (i.e. `sys::getDefaultTargetTriple()`).
It should not be an x86 triple by default.

Same for the cpu, you shouldn't default it to 'skylake' (why skylake? Also, x86 may not be in the list of available targets).
Basically, that flag should not be passed to llvm-mca if the user doesn't explicitly set it. llvm-mca would default mcpu to `llvm::sys::getHostCPUName()`.

About the flags:
do we actually need to specify -diff on the command line? Isn't it implicit if we pass multiple assembly files in input?

Also, (as a feature request) would it be possible to also get a diff of the resource pressure? Comparing the summary view is important. However, I believe that most users will also want to use your script to quickly see the differences in resource pressure.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115138/new/

https://reviews.llvm.org/D115138