[PATCH] D115330: [Dexter] Allow tests to specify their command line options

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando accepted this revision.
Orlando added a comment.
This revision is now accepted and ready to land.

Looks good, LGTM with two questions inline.



================
Comment at: cross-project-tests/debuginfo-tests/dexter/dex/debugger/DebuggerControllers/DebuggerControllerBase.py:33
+            cmd_line_objs = commands['DexCommandLine']
+            assert len(cmd_line_objs) == 1
+            cmd_line_obj = cmd_line_objs[0]
----------------
Probably a better user experience if this is caught in the parsing stage and prettily reported as an error. wdyt?


================
Comment at: cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/command_line.c:9-12
+  FILE *foo = fopen("/tmp/bees", "w");
+  fprintf(foo, "%d\n", argc);
+  fprintf(foo, "%s\n", argv[1]);
+  fclose(foo);
----------------
Is this part of the test (and the `#include`) necessary?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115330/new/

https://reviews.llvm.org/D115330