[llvm] 9b914aa - [llvm] Remove out-of-date fixme from SmallVectorMemoryBuffer
Jan Svoboda via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 8 02:54:00 PST 2021
Author: Jan Svoboda
Date: 2021-12-08T11:53:50+01:00
New Revision: 9b914aacbd5414e48fa2a58e0082e7b69c783278
URL: https://github.com/llvm/llvm-project/commit/9b914aacbd5414e48fa2a58e0082e7b69c783278
DIFF: https://github.com/llvm/llvm-project/commit/9b914aacbd5414e48fa2a58e0082e7b69c783278.diff
LOG: [llvm] Remove out-of-date fixme from SmallVectorMemoryBuffer
This fixme first appeared in the codebase with the introduction of `ObjectMemoryBuffer` in rG93de2a12a36feaf1e6d8ff28c76db9b6cda4e844, but the constructor appears to never have been templated.
Reviewed By: dexonsmith
Differential Revision: https://reviews.llvm.org/D115044
Added:
Modified:
llvm/include/llvm/Support/SmallVectorMemoryBuffer.h
Removed:
################################################################################
diff --git a/llvm/include/llvm/Support/SmallVectorMemoryBuffer.h b/llvm/include/llvm/Support/SmallVectorMemoryBuffer.h
index 9aa4e9aec266d..af748cf962b00 100644
--- a/llvm/include/llvm/Support/SmallVectorMemoryBuffer.h
+++ b/llvm/include/llvm/Support/SmallVectorMemoryBuffer.h
@@ -30,12 +30,6 @@ class SmallVectorMemoryBuffer : public MemoryBuffer {
public:
/// Construct an SmallVectorMemoryBuffer from the given SmallVector
/// r-value.
- ///
- /// FIXME: It'd be nice for this to be a non-templated constructor taking a
- /// SmallVectorImpl here instead of a templated one taking a SmallVector<N>,
- /// but SmallVector's move-construction/assignment currently only take
- /// SmallVectors. If/when that is fixed we can simplify this constructor and
- /// the following one.
SmallVectorMemoryBuffer(SmallVectorImpl<char> &&SV)
: SV(std::move(SV)), BufferName("<in-memory object>") {
init(this->SV.begin(), this->SV.end(), false);
More information about the llvm-commits
mailing list