[PATCH] D115229: [AMDGPU] In SIMemoryLegalizer assume all atomic ops have memoperands

[Jay Foad via Phabricator via llvm-commits]

foad planned changes to this revision.
foad added a comment.

In D115229#3177688 <https://reviews.llvm.org/D115229#3177688>, @arsenm wrote:

> This at least needs to be backed up with a verifier change.

I'm not ready to assert that all mayLoad/mayStore MIs have an MMO. I'm only saying that this seems to be true:

- for MIs used by the AMDGPU backend,
- which have the AMDGPU-specific maybeAtomic flag set.

I don't really understand the point of the maybeAtomic flag, so I might work on removing that first and then revisit this patch.

> Arguably this should be a general verifier property if we really can commit to machine passes never dropping MMOs

I wasn't aware that passes were allowed to drop MMOs. Do you know of any specific examples? It seems like a bit of an odd situation if they are allowed to, but it never actually happens in practice.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115229/new/

https://reviews.llvm.org/D115229