[PATCH] D115274: [IR][RFC] Memory region declaration intrinsic

[Clement Courbet via Phabricator via llvm-commits]

courbet added inline comments.


================
Comment at: llvm/docs/LangRef.rst:20409
+
+The '``llvm.memory.region.decl``' intrinsic annotates memory region.
+
----------------
*`a memory region`

Maybe even something like:

`annotates a pointer with memory region that is accessible through that pointer.`


================
Comment at: llvm/docs/LangRef.rst:20418
+as the argument. The second argument specifies the offset to the pointer (the
+first argument) at which the memory region begins. The third argument specifies
+the offset to the pointer (the first argument) at which the memory region ends.
----------------
Do we want to specify that `end_offset` > `begin_offset` ? 


================
Comment at: llvm/docs/LangRef.rst:20444-20446
+Given that pointer ``%ptr``, the only ``inbounds`` addresses can be computed
+by applying offsets that lie within ``[-8, 24]`` constraints, otherwise you get
+the :ref:`poison value <poisonvalues>`. (Provided that there actually is an
----------------
I have a hard time parsing that sentence, did you mean something like:

```
The only ``inbounds`` addresses that can be computed from pointer ``%ptr`` are those that lie within offsets ``[-8, 24]`` from that pointer.
Other offsets will result in a :ref:`poison value <poisonvalues>`.
```


================
Comment at: llvm/docs/LangRef.rst:20445
+Given that pointer ``%ptr``, the only ``inbounds`` addresses can be computed
+by applying offsets that lie within ``[-8, 24]`` constraints, otherwise you get
+the :ref:`poison value <poisonvalues>`. (Provided that there actually is an
----------------
Given the semantics above, 24 should be excluded: `[8,24)`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115274/new/

https://reviews.llvm.org/D115274