[PATCH] D110720: Verify inferattrs doesn't infer unexpected attributes
Ryan Prichard via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 7 21:39:25 PST 2021
rprichard accepted this revision.
rprichard added a comment.
This revision is now accepted and ready to land.
In D110720#3109821 <https://reviews.llvm.org/D110720#3109821>, @probinson wrote:
>> The lines where CHECK is split into CHECK-LINUX and CHECK-NOLINUX are also enabling the test for nvptx.
>
> It's true that the nvptx case is now checking more than it used to, but not everything; making it check everything could probably be done, but is it worthwhile? I experimented with passing CHECK to the nvptx case, and it doesn't pass; there would have to be a CHECK-NVPTX line paralleling each CHECK: line, pretty much. Seems like a lot of effort, but is nvptx really that special?
> I'll do it if someone says Yes, it's worth the trouble; but unless someone can say that, I'd rather not.
Ok, that makes sense to me.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110720/new/
https://reviews.llvm.org/D110720
More information about the llvm-commits
mailing list