[compiler-rt] 8ed4d28 - [NFC][lsan] Use kIgnored in MarkInvalidPCCb
Vitaly Buka via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 7 19:53:17 PST 2021
Author: Vitaly Buka
Date: 2021-12-07T19:53:08-08:00
New Revision: 8ed4d2819dff7743ab979d184433cba8bffed833
URL: https://github.com/llvm/llvm-project/commit/8ed4d2819dff7743ab979d184433cba8bffed833
DIFF: https://github.com/llvm/llvm-project/commit/8ed4d2819dff7743ab979d184433cba8bffed833.diff
LOG: [NFC][lsan] Use kIgnored in MarkInvalidPCCb
kIgnored didn't exist when the code was added, but it should be
equivalent to kReachable.
The goal is to refactor MarkInvalidPCCb to avoid StackDepotGet
in StopTheWorld.
Added:
Modified:
compiler-rt/lib/lsan/lsan_common.cpp
Removed:
################################################################################
diff --git a/compiler-rt/lib/lsan/lsan_common.cpp b/compiler-rt/lib/lsan/lsan_common.cpp
index 308dbb3e41dab..172561075a946 100644
--- a/compiler-rt/lib/lsan/lsan_common.cpp
+++ b/compiler-rt/lib/lsan/lsan_common.cpp
@@ -505,7 +505,7 @@ static void MarkInvalidPCCb(uptr chunk, void *arg) {
// it as reachable, as we can't properly report its allocation stack anyway.
if (caller_pc == 0 || (param->skip_linker_allocations &&
GetLinker()->containsAddress(caller_pc))) {
- m.set_tag(kReachable);
+ m.set_tag(kIgnored);
param->frontier->push_back(chunk);
}
}
More information about the llvm-commits
mailing list