[PATCH] D115105: [test-release.sh] Add an option to build lib projects as a part of default runtimes.

Amy Kwan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 7 14:16:21 PST 2021


amyk added a comment.

In D115105#3174149 <https://reviews.llvm.org/D115105#3174149>, @ldionne wrote:

> Nitpick: In your commit message, I think you mean `LLVM_ENABLE_RUNTIMES`, not `LLVM_ENABLE_PROJECTS`.
>
> I'm fine-ish with this change. Another approach would be D112748 <https://reviews.llvm.org/D112748>, where we automatically route various runtimes to `LLVM_ENABLE_RUNTIMES` without having to change how `test-release.sh` is invoked. I'm fine with either, I don't really have a preference.

Oops - yes, that is right. Thanks for letting me know @ldionne! And sorry for missing the initial Phabricator revision that was put up. I've actually added a few comments to your revision to keep the conversation more contained.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115105/new/

https://reviews.llvm.org/D115105



More information about the llvm-commits mailing list