[PATCH] D112748: [release] Use the Bootstrapping build for building LLVM releases

Amy Kwan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 7 14:16:08 PST 2021


amyk added a comment.

Thanks for putting up this patch (and taking a look at the revision I've put up). I've left a question on this patch to keep the conversation more contained.



================
Comment at: llvm/utils/release/test-release.sh:241
 if [ $do_rt = "yes" ]; then
   projects="$projects compiler-rt"
 fi
----------------
I was initially thinking that perhaps maybe we can opt for a hybrid of this idea and my idea in https://reviews.llvm.org/D115105 because I can see adding a new option for users to specifically control which projects people want to build as a part of runtimes, but then I realize, we're doing it this way where we just add to `runtimes` because the plan going forward is to only support building  `libcxx`/`libcxxabi`/`libunwind` as a part of runtimes, right? 

Since `compiler-rt` can also be built a part of runtimes, would it still make sense to also add this a part of `runtimes`? 
Unless if we introduce a new option to add the ability to build `compiler-rt` as apart of runtimes?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112748/new/

https://reviews.llvm.org/D112748



More information about the llvm-commits mailing list