[PATCH] D115173: [InstCombine] try to fold rem with constant dividend and select-of-constants divisor

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

In D115173#3177297 <https://reviews.llvm.org/D115173#3177297>, @lebedev.ri wrote:

> Could you please add this test: https://godbolt.org/z/WvYxnejnc (it should not optimize to unreachable/undef/poison)

Sure - added "0 select arm" tests for all 4 opcodes:
51d3cb0ab15d <https://reviews.llvm.org/rG51d3cb0ab15de7acb7131b5f967cf7fc84def99e>

> LGTM, but this reminds me of D71561 <https://reviews.llvm.org/D71561> that got stuck (sorry, that was not my intention),
> similar generalization could be applied here i believe.

I forgot about that patch...will try to revisit if I have time.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115173/new/

https://reviews.llvm.org/D115173