[PATCH] D114895: [SelectionDagBuilder] improve CallBrInst BlockAddress constraint handling

[Bill Wendling via Phabricator via llvm-commits]

void accepted this revision.
void added a comment.
This revision is now accepted and ready to land.

LGTM with the addition of another test case.



================
Comment at: llvm/test/CodeGen/X86/callbr-asm-outputs.ll:207
 }
+
+; Test5 - test that we don't rely on a positional constraint. ie. +r in
----------------
It might be good to have a test from one of your examples where a block addresses are used as inputs but not indirect destinations. From above:

```
int x;
void foo (void) {
    asm goto (
    "# %0\n\t"
    "# %1\n\t"
    "# %l2\n\t"
    : "=r"(x):"rm"(&&bar)::bar);
    bar:;
}
```



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114895/new/

https://reviews.llvm.org/D114895