[PATCH] D114534: [flang][runtime] Add ragged array runtime functions

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 7 10:25:47 PST 2021


clementval marked 5 inline comments as done.
clementval added inline comments.


================
Comment at: flang/include/flang/Runtime/ragged.h:27
+struct RaggedArrayHeader {
+  std::uint64_t flags{0u};
+  void *bufferPointer{nullptr};
----------------
klausler wrote:
> klausler wrote:
> > Could you convert the "flags" data member into a `bool` and a `std::uint8_t`?  It's just holding a flag and an integer in the range 1-15, if I understand this rightly.
> Ping; this is the last unaddressed comment.  Will this improvement be possible to make?
It's done just forgot to mark it as done. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114534/new/

https://reviews.llvm.org/D114534



More information about the llvm-commits mailing list