[PATCH] D113872: [CGP] Handle select instructions relying on the same condition

[Sotiris Apostolakis via Phabricator via llvm-commits]

apostolakis added a comment.

I was waiting for someone else to take a look as well since I am new in the reviewing process in llvm.
Maybe it would help to state if you have any motivating case that led to these changes and especially to the introduction of a new flag.

The updated flag is a bit better than the initial one and points out to the users that they need to think about misprediction penalty when tuning branch vs select heuristics.
Changing the Cmp->hasOneUse() and looking into all the selects of the group when considering the sinkSelectOperand heuristic are fine with me and in accordance with the logic behind these heuristics.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113872/new/

https://reviews.llvm.org/D113872