[PATCH] D115179: [NFC] Clarify comment about LoopDeletionPass in the optimization pipeline

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 7 09:59:22 PST 2021


lebedev.ri added a comment.

In D115179#3176871 <https://reviews.llvm.org/D115179#3176871>, @aeubanks wrote:

> In D115179#3174484 <https://reviews.llvm.org/D115179#3174484>, @lebedev.ri wrote:
>
>> FTR i will be rather surprised if that alone would fully alleviate the need for this late loopdelete.
>
> Changing the `EarlyCSEPass` in `PassBuilder::buildFunctionSimplificationPipeline()` to `GVNPass` does make `llvm/test/Transforms/PhaseOrdering/deletion-of-loops-that-became-side-effect-free.ll` pass if we delete the -O1 RUN line

I'm sure it does, but i think everyone understands that the test in question does not provide exhaustive test coverage for all possible affected code patterns.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115179/new/

https://reviews.llvm.org/D115179



More information about the llvm-commits mailing list