[llvm] 5c7e783 - [NFC] Clarify comment about LoopDeletionPass in the optimization pipeline

[Arthur Eubanks via llvm-commits]

Author: Arthur Eubanks
Date: 2021-12-07T09:58:12-08:00
New Revision: 5c7e783ebe41936e653ff5232344bd28777e3ceb

URL: https://github.com/llvm/llvm-project/commit/5c7e783ebe41936e653ff5232344bd28777e3ceb
DIFF: https://github.com/llvm/llvm-project/commit/5c7e783ebe41936e653ff5232344bd28777e3ceb.diff

LOG: [NFC] Clarify comment about LoopDeletionPass in the optimization pipeline

Reviewed By: lebedev.ri

Differential Revision: https://reviews.llvm.org/D115179

Added: 
    

Modified: 
    llvm/lib/Passes/PassBuilderPipelines.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Passes/PassBuilderPipelines.cpp b/llvm/lib/Passes/PassBuilderPipelines.cpp
index 490c69819cfd..dbfa2a4f90e1 100644
--- a/llvm/lib/Passes/PassBuilderPipelines.cpp
+++ b/llvm/lib/Passes/PassBuilderPipelines.cpp
@@ -1164,8 +1164,9 @@ PassBuilder::buildModuleOptimizationPipeline(OptimizationLevel Level,
   // Disable header duplication at -Oz.
   LPM.addPass(LoopRotatePass(Level != OptimizationLevel::Oz, LTOPreLink));
   // Some loops may have become dead by now. Try to delete them.
-  // FIXME: see disscussion in https://reviews.llvm.org/D112851
-  //        this may need to be revisited once GVN is more powerful.
+  // FIXME: see discussion in https://reviews.llvm.org/D112851,
+  //        this may need to be revisited once we run GVN before loop deletion
+  //        in the simplification pipeline.
   LPM.addPass(LoopDeletionPass());
   OptimizePM.addPass(createFunctionToLoopPassAdaptor(
       std::move(LPM), /*UseMemorySSA=*/false, /*UseBlockFrequencyInfo=*/false));