[PATCH] D115138: [llvm-mca] Compare multiple files

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 7 08:25:09 PST 2021


RKSimon added a comment.

Not to descend into bike shedding, but is llvm-mca-pretty-printer.py a suitable name?



================
Comment at: llvm/utils/llvm-mca-pretty-printer/llvm-mca-pretty-printer.py:33
+  parser.add_argument('-iterations', type = int, nargs = 1, action = 'store', default = [100], help = 'Number of iterations to run.')
+  parser.add_argument('-useMca', nargs = 1, type = str, action = 'store', help = 'Specified relative path to llvm-mca.')
+  return parser.parse_args()
----------------
djtodoro wrote:
> `-use-mca` ?
If we follow the style used by the llvm\utils\update_*_test_checks.py scripts - this should be:

```
--llvm-mca-binary=<path to llvm-mca>
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115138/new/

https://reviews.llvm.org/D115138



More information about the llvm-commits mailing list