[PATCH] D112450: support xcoff for llvm-nm

[Digger Lin via Phabricator via llvm-commits]

DiggerLin marked 4 inline comments as done.
DiggerLin added inline comments.


================
Comment at: llvm/test/tools/llvm-nm/XCOFF/basic.test:24-25
+# NM-SYM-NEXT: 00000000 t .text
+
+# NM-SYM:      00000104 d _Z5func1i
+# NM-SYM-NEXT: 0000010c D _Z5func1i
----------------
jhenderson wrote:
> Why are you not using check-next here? Are there symbols you are deliberately ignoring in this case?
yes,  for the convenience to review.  there are some symbols are ignore in the case. 


================
Comment at: llvm/test/tools/llvm-nm/XCOFF/basic.test:31
+# NM-SYM-NEXT: 0000011c W weak_value
+~
----------------
jhenderson wrote:
> Why's this line here?
thanks . delete it.


================
Comment at: llvm/tools/llvm-nm/llvm-nm.cpp:942-943
+
+  // If the I->getSection() return error, the I->getType() will return same
+  // error first, it will not come to here.
+  section_iterator SecIter = cantFail(I->getSection());
----------------
jhenderson wrote:
> Some suggested improvements. Please reflow too.
thanks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112450/new/

https://reviews.llvm.org/D112450