[PATCH] D115138: [llvm-mca] Compare multiple files

Djordje Todorovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 7 07:48:12 PST 2021


djtodoro added inline comments.


================
Comment at: llvm/utils/llvm-mca-pretty-printer/llvm-mca-pretty-printer.py:33
+  parser.add_argument('-iterations', type = int, nargs = 1, action = 'store', default = [100], help = 'Number of iterations to run.')
+  parser.add_argument('-useMca', nargs = 1, type = str, action = 'store', help = 'Specified relative path to llvm-mca.')
+  return parser.parse_args()
----------------
`-use-mca` ?


================
Comment at: llvm/utils/llvm-mca-pretty-printer/llvm-mca-pretty-printer.py:39
+  if len(sys.argv) < 2 :
+    print ('error: Wrong number of arguments.')
+    return False
----------------
Can this be more descriptive?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115138/new/

https://reviews.llvm.org/D115138



More information about the llvm-commits mailing list