[PATCH] D115244: [LICM] Promote conditional, loop-invariant memory accesses to scalars

[Dimitrije Milošević via Phabricator via llvm-commits]

dmilosevic141 marked 3 inline comments as done.
dmilosevic141 added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LICM.cpp:145
+// them.
+cl::opt<bool> SetLicmConditionalAccessPromotion(
+    "licm-conditional-access-promotion", cl::Hidden, cl::init(false),
----------------
djtodoro wrote:
> IIUC, this should be target-independent optimization? And, GCC generates such code for both x86_64 and aarch64, right?
> 
> The generated code will be bigger, so this will impact the code size, so I guess this needs motivation in terms of (SPEC) benchmarking.
> IIUC, this should be target-independent optimization? And, GCC generates such code for both x86_64 and aarch64, right?
Correct, //GCC// (excluding the //Ofast// optimization level, which allows data races) generates such code for both //x86_64// and //AArch64//, hence why this should be target-independent.
> The generated code will be bigger, so this will impact the code size, so I guess this needs motivation in terms of (SPEC) benchmarking.
Sure, will work on that.






CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115244/new/

https://reviews.llvm.org/D115244