[llvm] 420300c - [MCA] Remove the warning about experimental support for in-order CPU
Andrew Savonichev via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 7 04:28:52 PST 2021
Author: Andrew Savonichev
Date: 2021-12-07T15:27:51+03:00
New Revision: 420300c0d8d9afbc7ea74ce9d5702ac6de58ba6e
URL: https://github.com/llvm/llvm-project/commit/420300c0d8d9afbc7ea74ce9d5702ac6de58ba6e
DIFF: https://github.com/llvm/llvm-project/commit/420300c0d8d9afbc7ea74ce9d5702ac6de58ba6e.diff
LOG: [MCA] Remove the warning about experimental support for in-order CPU
There are not a lot of bug reports for this feature, so let's mark it
stable.
Differential Revision: https://reviews.llvm.org/D114701
Added:
Modified:
llvm/test/tools/llvm-mca/X86/in-order-cpu.s
llvm/tools/llvm-mca/llvm-mca.cpp
Removed:
################################################################################
diff --git a/llvm/test/tools/llvm-mca/X86/in-order-cpu.s b/llvm/test/tools/llvm-mca/X86/in-order-cpu.s
index fcf4422bbbb4a..9d8f74d470a27 100644
--- a/llvm/test/tools/llvm-mca/X86/in-order-cpu.s
+++ b/llvm/test/tools/llvm-mca/X86/in-order-cpu.s
@@ -1,5 +1,36 @@
# NOTE: Assertions have been autogenerated by utils/update_mca_test_checks.py
-# RUN: llvm-mca %s -mtriple=x86_64-unknown-unknown -mcpu=atom -o /dev/null 2>&1 | FileCheck %s
+# RUN: llvm-mca %s -mtriple=x86_64-unknown-unknown -mcpu=atom | FileCheck %s
movsbw %al, %di
-# CHECK: warning: support for in-order CPU 'atom' is experimental.
+# CHECK: Iterations: 100
+# CHECK-NEXT: Instructions: 100
+# CHECK-NEXT: Total Cycles: 101
+# CHECK-NEXT: Total uOps: 100
+
+# CHECK: Dispatch Width: 2
+# CHECK-NEXT: uOps Per Cycle: 0.99
+# CHECK-NEXT: IPC: 0.99
+# CHECK-NEXT: Block RThroughput: 1.0
+
+# CHECK: Instruction Info:
+# CHECK-NEXT: [1]: #uOps
+# CHECK-NEXT: [2]: Latency
+# CHECK-NEXT: [3]: RThroughput
+# CHECK-NEXT: [4]: MayLoad
+# CHECK-NEXT: [5]: MayStore
+# CHECK-NEXT: [6]: HasSideEffects (U)
+
+# CHECK: [1] [2] [3] [4] [5] [6] Instructions:
+# CHECK-NEXT: 1 2 1.00 movsbw %al, %di
+
+# CHECK: Resources:
+# CHECK-NEXT: [0] - AtomPort0
+# CHECK-NEXT: [1] - AtomPort1
+
+# CHECK: Resource pressure per iteration:
+# CHECK-NEXT: [0] [1]
+# CHECK-NEXT: 1.00 1.00
+
+# CHECK: Resource pressure by instruction:
+# CHECK-NEXT: [0] [1] Instructions:
+# CHECK-NEXT: 1.00 1.00 movsbw %al, %di
diff --git a/llvm/tools/llvm-mca/llvm-mca.cpp b/llvm/tools/llvm-mca/llvm-mca.cpp
index 0b58ca377ce13..0501336ab2077 100644
--- a/llvm/tools/llvm-mca/llvm-mca.cpp
+++ b/llvm/tools/llvm-mca/llvm-mca.cpp
@@ -347,12 +347,6 @@ int main(int argc, char **argv) {
if (!STI->isCPUStringValid(MCPU))
return 1;
- bool IsOutOfOrder = STI->getSchedModel().isOutOfOrder();
- if (!PrintInstructionTables && !IsOutOfOrder) {
- WithColor::warning() << "support for in-order CPU '" << MCPU
- << "' is experimental.\n";
- }
-
if (!STI->getSchedModel().hasInstrSchedModel()) {
WithColor::error()
<< "unable to find instruction-level scheduling information for"
@@ -367,6 +361,7 @@ int main(int argc, char **argv) {
}
// Apply overrides to llvm-mca specific options.
+ bool IsOutOfOrder = STI->getSchedModel().isOutOfOrder();
processViewOptions(IsOutOfOrder);
std::unique_ptr<MCRegisterInfo> MRI(TheTarget->createMCRegInfo(TripleName));
More information about the llvm-commits
mailing list