[PATCH] D114159: [flang][codegen] Add a conversion for `fir.coordinate_of` - part 1

Andrzej Warzynski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 7 03:34:15 PST 2021


awarzynski updated this revision to Diff 392335.
awarzynski added a comment.

Allow dynamically sized arrays inside `!fir.box`.

I mistakenly disallowed dynamically sized arrays earlier. However, IIUC, boxed arrays (and that's the only type of arrays dealt with in this patch) shouldn't require size when using `fir.coordinate_of`. In fact, `!fir.box<!fir.array<? x i32>>` should be no different to `!fir.box<!fir.array<? x i32>>` in this case. Updated accordingly. @rovka, could you take one final look?

Also rebased on top of main.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114159/new/

https://reviews.llvm.org/D114159

Files:
  flang/lib/Optimizer/CodeGen/CodeGen.cpp
  flang/lib/Optimizer/CodeGen/TypeConverter.h
  flang/test/Fir/Todo/cordinate_of_1.fir
  flang/test/Fir/Todo/cordinate_of_2.fir
  flang/test/Fir/convert-to-llvm.fir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D114159.392335.patch
Type: text/x-patch
Size: 32618 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211207/6fb59910/attachment.bin>


More information about the llvm-commits mailing list