[PATCH] D114457: [z/OS] Implement prologue and epilogue generation for z/OS target.

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 7 03:19:04 PST 2021


uweigand added a comment.

In D114457#3174537 <https://reviews.llvm.org/D114457#3174537>, @Kai wrote:

> Well, thinking about all this I guess the best way forward is:
>
> - not using the LocalAreaOffset, because it has a different semantic
> - get rid of `getAllocatedStackSize()`
> - use "incoming SP + stackbias" as base for all stack offset calculations, because that is more obvious

Agreed.  For the last part, the only thing that needs to change is the fixed stack offsets for the parameter slots, which now need to include the 128 byte area.  This could be done locally in `LowerFormalParameters` when doing the `CreateFixedObject` call.  But I suspect it might be more straightforward to change the offset computation in SystemZCallingConvention.td to have the correct offset in `VA.getLocMemOffset()` to begin with.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114457/new/

https://reviews.llvm.org/D114457



More information about the llvm-commits mailing list