[PATCH] D113420: [WebAssembly] Implement table instruction intrinsics and ref.null

[Paulo Matos via Phabricator via llvm-commits]

pmatos added inline comments.


================
Comment at: llvm/test/CodeGen/WebAssembly/table-copy.ll:29
+; Copies len items from table1 at src to table1 at src+off
+define void @self_table_copy(i32 %src, i32 %off, i32 %len) {
+; CHECK-LABEL: self_table_copy:
----------------
tlively wrote:
> pmatos wrote:
> > @tlively is this the kind of test you were referring to?
> Looks good! I was probably thinking of having different offsets in the `getelementptr`, but not supporting that for now and taking the offsets as arguments to the copy intrinsic seems much simpler.
Humm, I see what you mean but isn't it always the case that since we are dereferencing a global, the GEP will always have zero offsets? I cannot imagine a case, where we use non-zero offsets to dereference a global representing a table, like we do for example in the `llvm/test/CodeGen/WebAssembly/funcref-tableget.ll` test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113420/new/

https://reviews.llvm.org/D113420