[PATCH] D115225: [X86][MS-InlineAsm] Make the constraint *m to be simple place holder

Phoebe Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 7 01:11:20 PST 2021


pengfei created this revision.
pengfei added reviewers: skan, xiangzhangllvm, craig.topper, coby.
Herald added a subscriber: hiraditya.
pengfei requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.

D113096 <https://reviews.llvm.org/D113096> solved the "undefined reference to xxx" issue by adding
constraint *m for the global var. But it has strong side effect due to
the symbol in the assembly being replace with constraint variable.
This leads to some lowering fails. https://godbolt.org/z/h3nWoerPe

This patch fix the problem by use the constraint *m as place holder
rather than real constraint. It has negligible effect for the existing
code generation.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D115225

Files:
  clang/test/CodeGen/X86/ms_fmul.c
  clang/test/CodeGen/ms-inline-asm-functions.c
  clang/test/CodeGen/ms-inline-asm-static-variable.c
  clang/test/CodeGen/ms-inline-asm-variables.c
  llvm/include/llvm/MC/MCParser/MCParsedAsmOperand.h
  llvm/lib/MC/MCParser/AsmParser.cpp
  llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp
  llvm/lib/Target/X86/AsmParser/X86Operand.h
  llvm/test/CodeGen/X86/ms-inline-asm-array.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D115225.392307.patch
Type: text/x-patch
Size: 7254 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211207/22c2f8b2/attachment.bin>


More information about the llvm-commits mailing list