[PATCH] D115222: [Coroutines] Remove unused coroutine builtin/intrinsics llvm.coro.param (NFC-ish)

[Chuanqi Xu via Phabricator via llvm-commits]

ChuanqiXu created this revision.
ChuanqiXu added reviewers: rjmccall, lxfind, junparser, ychen.
ChuanqiXu added projects: clang, LLVM.
Herald added a subscriber: hiraditya.
ChuanqiXu requested review of this revision.
Herald added subscribers: llvm-commits, cfe-commits, jdoerfert.

I found that the coroutine intrinsic `llvm.coro.param` in documentation (https://llvm.org/docs/Coroutines.html#id101) didn't get used actually since there isn't lowering codes in LLVM. I also checked the implementation of libstdc++ and libc++. Both of them didn't use `llvm.coro.param`. So I am pretty sure that the `llvm.coro.param` intrinsic is unused. I think it would be better t to remove it to avoid possible misleading understandings.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D115222

Files:
  clang/docs/LanguageExtensions.rst
  clang/include/clang/Basic/Builtins.def
  clang/lib/CodeGen/CGBuiltin.cpp
  clang/test/CodeGenCoroutines/coro-builtins.c
  llvm/docs/Coroutines.rst
  llvm/include/llvm/Analysis/TargetTransformInfoImpl.h
  llvm/include/llvm/IR/Intrinsics.td
  llvm/lib/Transforms/Coroutines/Coroutines.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D115222.392289.patch
Type: text/x-patch
Size: 7154 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211207/28f2e573/attachment.bin>