[PATCH] D115041: [ELF] Do not report undefined weak references in shared libraries

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 6 19:21:03 PST 2021


ikudrin marked an inline comment as done.
ikudrin added inline comments.


================
Comment at: lld/test/ELF/allow-shlib-undefined-weak.test:1
+REQUIRES: x86
+
----------------
jrtc27 wrote:
> The trouble with a .test is then you don't get syntax highlighting for the assembly...
> 
> .s with commented-out REQUIRES/RUN is better IMO
> The trouble with a .test is then you don't get syntax highlighting for the assembly...
> 
> .s with commented-out REQUIRES/RUN is better IMO

Makes sense, thanks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115041/new/

https://reviews.llvm.org/D115041



More information about the llvm-commits mailing list