[PATCH] D102817: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 2

Daniel Paoliello via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 6 15:46:56 PST 2021


dpaoliello added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1321
+              (MI2->mayLoadOrStore() || MI2->mayRaiseFPException()))
+            emitNops(1);
+        }
----------------
Is this still required? LLVM is no longer adding 1 to the addresses in its SEH tables (although it does for its IP2State table).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102817/new/

https://reviews.llvm.org/D102817



More information about the llvm-commits mailing list