[PATCH] D114194: [SystemZ] Add range checks for PC-relative fixups

Jonas Paulsson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 6 15:27:15 PST 2021


jonpa updated this revision to Diff 392207.
jonpa added a comment.

Updated per review.

> I think it's better to be explicit, so the message for displacements should mirror the one here.

ok - updated patch and tests for this.

> As to the test, I don't really like the checking for explicit line:column numbers - this will make those test awkward to change in the future. Isn't it enough to identify a particular line by the label number used in it (assuming you make label uses unique, which can be easily done by sometimes putting two labels on the same location).

Removed line numbers - I think that should work ok with the CHECK-NEXT:s and the final 'CHECK-NOT'...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114194/new/

https://reviews.llvm.org/D114194

Files:
  llvm/lib/Target/SystemZ/MCTargetDesc/SystemZMCAsmBackend.cpp
  llvm/lib/Target/SystemZ/MCTargetDesc/SystemZMCCodeEmitter.cpp
  llvm/test/MC/SystemZ/fixups-out-of-range-01.s
  llvm/test/MC/SystemZ/fixups-out-of-range-02.s
  llvm/test/MC/SystemZ/fixups-out-of-range.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D114194.392207.patch
Type: text/x-patch
Size: 6373 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211206/d5c9e768/attachment.bin>


More information about the llvm-commits mailing list