[PATCH] D115189: [Support] [Debuginfod] Include curl include dirs when curl is enabled. (WIP)

[Petr Hosek via Phabricator via llvm-commits]

phosek added inline comments.


================
Comment at: llvm/lib/Support/CMakeLists.txt:79
 if (LLVM_ENABLE_CURL)
   set(system_libs ${system_libs} ${CURL_LIBRARIES})
 endif()
----------------
You need to use the imported library here instead which configures both the include directory and the library. See zlib case above where we do the same.


================
Comment at: llvm/lib/Support/CMakeLists.txt:296
 endif()
 
 set_property(TARGET LLVMSupport PROPERTY LLVM_SYSTEM_LIBS "${llvm_system_libs}")
----------------
You also need to replicate the ZLIB block above for CURL here.


================
Comment at: llvm/lib/Support/CMakeLists.txt:318-323
+if(LLVM_ENABLE_CURL)
+  target_include_directories(LLVMSupport SYSTEM
+    PRIVATE
+    ${CURL_INCLUDE_DIRS}
+    )
+endif()
----------------
This shouldn't be needed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115189/new/

https://reviews.llvm.org/D115189