[PATCH] D115175: Remove Colours array in -print-changed=dot-cfg

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 6 12:35:26 PST 2021


aeubanks added inline comments.


================
Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:1272
   // Is this in before, after, or both?
-  IRChangeDiffType getType() const { return Type; }
+  StringRef getColour() const { return Colour; }
 
----------------
should this be a `std::string`? it looks like it's referencing a `std::string` in `DisplayEdge::DisplayEdge()` that goes out of scope


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115175/new/

https://reviews.llvm.org/D115175



More information about the llvm-commits mailing list