[PATCH] D115013: [llvm-profgen] Fix total samples related issues

[Hongtao Yu via Phabricator via llvm-commits]

hoy accepted this revision.
hoy added a comment.
This revision is now accepted and ready to land.

lgtm, thanks.



================
Comment at: llvm/tools/llvm-profgen/ProfileGenerator.cpp:500
+        FunctionSamples &FunctionProfile = getLeafProfileAndAddTotalSamples(
+            FrameVec, Count * Binary->getInstSize(Offset));
         updateBodySamplesforFunctionProfile(FunctionProfile, FrameVec.back(),
----------------
wlei wrote:
> hoy wrote:
> > This doesn't really makes sense. Wondering how much it matters, compared to other places that affect total samples.
> This place caused 0.1% regression(I confirmed it's not noise) on unicorn, no regression on ads. With others together, they caused ~0.5% regression on unicorn.
Thanks for the update. Looks like we need to keep this. Please add a comment for this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115013/new/

https://reviews.llvm.org/D115013