[PATCH] D111237: [TypePromotion] Promote PHI + [SZ]Ext

[Andre Vieira via Phabricator via llvm-commits]

avieira added a comment.

In D111237#3173897 <https://reviews.llvm.org/D111237#3173897>, @samparker wrote:

>> I could alternatively try to avoid generating the trunc
>
> Yes, there's a TODO about avoiding the insertion in TypePromotion::isSink

I see. Am I misreading this or is the TODO saying we don't need isSink? That's a rather odd one ;) I could add some code to return isSink for the user of a PHI node if that PHI node only has a single use. That would work for the ZExt case, as that's recognized in isSink.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111237/new/

https://reviews.llvm.org/D111237