[PATCH] D114936: [llvm-c] Add header deprecations

Mon Dec 6 07:03:37 PST 2021

nikic added a comment.

In D114936#3173327 <https://reviews.llvm.org/D114936#3173327>, @uabelho wrote:

> Hi,
>
> I think more fixes are needed. With this commit I see:
>
>   ../unittests/ExecutionEngine/MCJIT/MCJITCAPITest.cpp:206:5: error: 'LLVMBuildCall' is deprecated: Use LLVMBuildCall2 instead to support opaque pointers [-Werror,-Wdeprecated-declarations]
>       LLVMBuildCall(builder, stackmap, stackmapArgs, 3, "");
>       ^
>   ../include/llvm-c/Core.h:3985:1: note: 'LLVMBuildCall' has been explicitly marked deprecated here
>   LLVM_ATTRIBUTE_C_DEPRECATED(
>   ^
>   ../include/llvm-c/Deprecated.h:26:23: note: expanded from macro 'LLVM_ATTRIBUTE_C_DEPRECATED'
>     decl __attribute__((deprecated(message)))
>                         ^
>   ../unittests/ExecutionEngine/MCJIT/MCJITCAPITest.cpp:233:31: error: 'LLVMBuildLoad' is deprecated: Use LLVMBuildLoad2 instead to support opaque pointers [-Werror,-Wdeprecated-declarations]
>           LLVMValueRef IntVal = LLVMBuildLoad(Builder, GlobalVar, "intVal");
>                                 ^
>   ../include/llvm-c/Core.h:3885:1: note: 'LLVMBuildLoad' has been explicitly marked deprecated here
>   LLVM_ATTRIBUTE_C_DEPRECATED(
>   ^
>   ../include/llvm-c/Deprecated.h:26:23: note: expanded from macro 'LLVM_ATTRIBUTE_C_DEPRECATED'
>     decl __attribute__((deprecated(message)))
>                         ^
>   ../unittests/ExecutionEngine/MCJIT/MCJITCAPITest.cpp:492:25: error: 'LLVMBuildCall' is deprecated: Use LLVMBuildCall2 instead to support opaque pointers [-Werror,-Wdeprecated-declarations]
>     LLVMValueRef RetVal = LLVMBuildCall(Builder, MappedFn, nullptr, 0, "");
>                           ^
>   ../include/llvm-c/Core.h:3985:1: note: 'LLVMBuildCall' has been explicitly marked deprecated here
>   LLVM_ATTRIBUTE_C_DEPRECATED(
>   ^
>   ../include/llvm-c/Deprecated.h:26:23: note: expanded from macro 'LLVM_ATTRIBUTE_C_DEPRECATED'
>     decl __attribute__((deprecated(message)))
>                         ^
>   3 errors generated.

Oops, sorry about that, I missed building the unit tests once again. Should be fixed by https://github.com/llvm/llvm-project/commit/24a72dc070b36d9e62d6b84abe5f1912c5a49581.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114936/new/

https://reviews.llvm.org/D114936