[PATCH] D115155: [tsan] Move tsan/rtl build rules into tsan/rtl/CMakeLists.txt

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.


================
Comment at: compiler-rt/lib/tsan/rtl/CMakeLists.txt:1
+include_directories(../..)
+
----------------
This file is identical to what I removed from the other file, except:
* this line grew and additional `../`


================
Comment at: compiler-rt/lib/tsan/rtl/CMakeLists.txt:20
+set(TSAN_SOURCES
+  tsan_clock.cpp
+  tsan_debugging.cpp
----------------
* the source list lost the leading `rtl/` on all lines


================
Comment at: compiler-rt/lib/tsan/rtl/CMakeLists.txt:159
+  # Build and check Go runtime.
+  set(BUILDGO_SCRIPT ${CMAKE_CURRENT_SOURCE_DIR}/../go/buildgo.sh)
+  add_custom_target(GotsanRuntimeCheck
----------------
* All the go rules grew an `/..` after `${CMAKE_CURRENT_SOURCE_DIR}`

(kind of feels the go rules should be in tsan/go/CMakeLists.txt maybe)


================
Comment at: compiler-rt/lib/tsan/rtl/CMakeLists.txt:162
+    COMMAND env "CC=${CMAKE_C_COMPILER} ${OSX_SYSROOT_FLAG}"
+            EXTRA_CFLAGS=${EXTRA_CFLAGS}
+            IN_TMPDIR=1 SILENT=1 ${BUILDGO_SCRIPT}
----------------
* (i removed a trailing space on this line and on the same line a bit below)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115155/new/

https://reviews.llvm.org/D115155