[PATCH] D115138: [llvm-mca] Compare multiple files

[Andrea Di Biagio via Phabricator via llvm-commits]

andreadb added a comment.

Hi @mmatic05 ,

Thanks for contributing this patch. However, I have a few questions/concerns regarding your suggested design.

Is there a reason why this feature should be implemented as part of llvm-mca?

Wouldn't it be simpler to contribute this feature as a separate script or tool?

You could have a python script that simply drives multiple mca runs under the hood, and then collects the json output from each individual run. That same script would then also `diff` the various outputs and pretty-print the result either as normal text, or as yet-another json file.

That way, you would be able to provide your new feature without having to change llvm-mca.
Any extension/customization on the diffing logic would be fully transparent to the main llvm-mca driver.

What do you think?

-Andrea


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115138/new/

https://reviews.llvm.org/D115138