[PATCH] D108763: Use type sizes when determining dependence

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 6 04:31:44 PST 2021


sdesmalen added a comment.

@fhahn can you help me understand your comment on the test so that I can address it before I land the patch? (@jolanta.jensen is OoO and I was asked to land the patch on her behalf)



================
Comment at: llvm/test/Analysis/LoopAccessAnalysis/depend_diff_types.ll:134
+  %11 = trunc i64 %7 to i19
+  store i19 %11, i19* %10, align 8
+
----------------
fhahn wrote:
> can you also throw in a read or write to a 32 bit type? Might be good to move those into a separate test.
Can you be a bit more specific about what you'd like to see? I can't quickly see what added value a read/write to 32bit type would add here. Or see which part needs moving to a separate test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108763/new/

https://reviews.llvm.org/D108763



More information about the llvm-commits mailing list