[PATCH] D115138: [llvm-mca] Compare multiple files

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added a comment.

Thanks for this! (I am not very familiar with this code, but the motivation sounds reasonable -- some nits included)



================
Comment at: llvm/test/tools/llvm-mca/X86/Inputs/diff-option-file-3.s:65
+
+	.ident	"clang version 14.0.0 (https://github.com/mmatic05/llvm-project.git 00f463e835d4baa285bc488c9fcb859e0461e452)"
+	.section	".note.GNU-stack","", at progbits
----------------
`(https://github.com/mmatic05/llvm-project.git 00f463e835d4baa285bc488c9fcb859e0461e452)` not needed


================
Comment at: llvm/test/tools/llvm-mca/X86/Inputs/diff-option-file-4.s:45
+
+	.ident	"clang version 14.0.0 (https://github.com/mmatic05/llvm-project.git 00f463e835d4baa285bc488c9fcb859e0461e452)"
+	.section	".note.GNU-stack","", at progbits
----------------
(https://github.com/mmatic05/llvm-project.git 00f463e835d4baa285bc488c9fcb859e0461e452) not needed




================
Comment at: llvm/tools/llvm-mca/MachineCodePerformance.cpp:1
+//===----------------------------------------------------------------------===//
+/// \file
----------------
This is missing the license information.


================
Comment at: llvm/tools/llvm-mca/MachineCodePerformance.h:11
+///
+/// This file implements class MachineCodePerformance.
+///
----------------
I guess this should go into the cpp unit.


================
Comment at: llvm/tools/llvm-mca/Views/ResourcePressureView.h:100
+  void getResourcePressurePerIter(
+      SmallVector<std::string> &ResourcePressurePerIter) const;
+  void printColNamesOfResourcePressurePerIter(raw_ostream &OS,
----------------
`SmallVectorImpl` instead?


================
Comment at: llvm/tools/llvm-mca/llvm-mca.cpp:461
 
+  if (MCSM == nullptr) {
+    MCSM = std::make_unique<MCSchedModel>(STI->getSchedModel());
----------------
no need for the curly brackets here


================
Comment at: llvm/tools/llvm-mca/llvm-mca.cpp:592
 
+    if (PrintDifference) {
+      MCP = std::make_unique<mca::MachineCodePerformance>(
----------------
here as well


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115138/new/

https://reviews.llvm.org/D115138