[PATCH] D115077: [fir] Add array operations documentation

[Valentin Clement via Phabricator via llvm-commits]

clementval added inline comments.


================
Comment at: flang/docs/FIRArrayOperations.md:202
+pass. This pass is called the `array-value-copy` pass.
+The analysis detects if there are any conflicts. A conflicts is when one of the
+following cases occurs:
----------------
rovka wrote:
> rovka wrote:
> > 
> So, IIUC, the 'array-value-copy' is both an analysis pass and a transformation pass, right? I think it would be good to clarify that up front, because I wasn't 100% certain of that until I saw there's a before/after example below. Also explain exactly what the pass does, since it seems to be more than just copy elision, which was what I first understood when I read this text.
> 
> 
The transformation needs an analysis first to be performed. More description of the pass should go directly in the pass file itself. The purpose of having an example here is just to show some array operations in use in a bigger example. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115077/new/

https://reviews.llvm.org/D115077