[PATCH] D113717: [Symbolizer][Debuginfo] Add debuginfod client to llvm-symbolizer.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-symbolizer/debuginfod.test:10
+# Symbolizing the stripped binary should fail.
+RUN: DEBUGINFOD_CACHE_PATH=%t llvm-symbolizer --print-address \
+RUN:   --obj=%t/addr.exe 0x40054d | FileCheck %s --check-prefix=NOTFOUND
----------------
I feel like runtime environment variables are usually prefixed with `env`. I suspect there's a good reason for this (maybe something Windows-specific?), so you probably need that too here, at a guess.


================
Comment at: llvm/test/tools/llvm-symbolizer/debuginfod.test:23
+
+# The symbolizer should call debuginfod client library, which finds the
+# debuginfo placed in the cache, enabling symbolization of the address.
----------------



================
Comment at: llvm/test/tools/llvm-symbolizer/debuginfod.test:25
+# debuginfo placed in the cache, enabling symbolization of the address.
+RUN: DEBUGINFOD_CACHE_PATH=%t llvm-symbolizer --print-address \
+RUN:   --obj=%t/addr.exe 0x40054d | FileCheck %s --check-prefix=FOUND
----------------
You don't use the `--print-address` option here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113717/new/

https://reviews.llvm.org/D113717