[PATCH] D114940: [OMPIRBuilder] Support ordered clause specified without parameter
Peixin Qiao via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Dec 5 23:39:22 PST 2021
peixin added inline comments.
================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:125-130
+ OrderedStaticChunked = 65,
+ OrderedStatic = 66, // ordered static unspecialized
+ OrderedDynamicChunked = 67,
+ OrderedGuidedChunked = 68,
+ OrderedRuntime = 69,
+ OrderedAuto = 70, // ordered auto
----------------
Meinersbur wrote:
> Did you consider making `ordered` a mask flag like Monotonic/Nonmonotonic?
These values are copied from "kmp.h". I prefer to keep the originl definition rather than using a mask flag. In addition, the ordered values don't have the consistent mask such as kmp_sch_upper and kmp_ord_upper in "kmp.h".
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114940/new/
https://reviews.llvm.org/D114940
More information about the llvm-commits
mailing list