[PATCH] D113717: [Symbolizer][Debuginfo] Add debuginfod client to llvm-symbolizer.

[Noah Shutty via Phabricator via llvm-commits]

noajshu added a comment.

Thanks for your suggestions on the end-to-end tests @jhenderson. Following a discussion here <https://reviews.llvm.org/D112758#inline-1099006> about testing strategy, I think we only need to test the integration point in the symbolizer here, which we achieve with the simpler test that just hits the cache. I have removed the more complicated python HTTP server test from this diff and moved it to D112759 <https://reviews.llvm.org/D112759> where it was adapted to test the `llvm-debuginfod-find` client instead and incorporate your feedback to make it more self-documenting.

Without the bulkier test this diff is nice and small. How does it look to you?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113717/new/

https://reviews.llvm.org/D113717